Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WJ-994] Fix framerail build in Docker #1889

Merged
merged 9 commits into from
Apr 22, 2024
Merged

[WJ-994] Fix framerail build in Docker #1889

merged 9 commits into from
Apr 22, 2024

Conversation

emmiegit
Copy link
Member

@emmiegit emmiegit commented Apr 22, 2024 •
edited
Loading

Create the Dockerfile for the web container in dev, and workflow files. Here is the dev/prod Dockerfile running locally:
screenshot

Notes

  • In the screenshot, it is not properly connected to the database and services, but the point is to show that it runs.
  • The Typescript CI failure is a separate issue from the Docker builds being added/fixed in this PR.

@emmiegit emmiegit self-assigned this Apr 22, 2024
@emmiegit emmiegit marked this pull request as ready for review April 22, 2024 06:01
@emmiegit emmiegit requested a review from Zokhoi as a code owner April 22, 2024 06:01
@emmiegit emmiegit merged commit 2896521 into develop Apr 22, 2024
6 of 7 checks passed
@emmiegit emmiegit deleted the WJ-994-dev-docker branch April 22, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zokhoi Zokhoi Zokhoi approved these changes

Assignees

@emmiegit emmiegit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emmiegit @Zokhoi